Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bigger, scrollable URL subscription text field #517

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Bigger, scrollable URL subscription text field #517

merged 1 commit into from
Feb 17, 2025

Conversation

sunkup
Copy link
Member

@sunkup sunkup commented Feb 17, 2025 •
edited
Loading

Purpose

Makes the URL subscription text field bigger and enables user to scroll forward and backward.

Short description

  • disable single line
  • set maxLines to 8

For me that's enough to also be able to scroll the content of the text field

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@sunkup sunkup added the bug Something isn't working label Feb 17, 2025
@sunkup sunkup requested a review from ArnyminerZ February 17, 2025 13:21
@sunkup sunkup self-assigned this Feb 17, 2025
@sunkup sunkup linked an issue Feb 17, 2025 that may be closed by this pull request
Long URLs can't be scrolled #515
Closed
ArnyminerZ
ArnyminerZ approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@ArnyminerZ ArnyminerZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@ArnyminerZ ArnyminerZ merged commit 6012e79 into dev Feb 17, 2025
12 checks passed
@ArnyminerZ ArnyminerZ deleted the 515-long-urls-cant-be-scrolled branch February 17, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArnyminerZ ArnyminerZ ArnyminerZ approved these changes

Assignees

@sunkup sunkup

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Long URLs can't be scrolled
2 participants
@sunkup @ArnyminerZ